Bug 181034 – Replace a FIXME comment in CanvasGradient::addColorStop().

• Component: Canvas
• Status: RESOLVED FIXED

[Ms2ger (he/him; ⌚ UTC+1/+2)]

.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 329917 [details]
Patch

[Daniel Bates]

Comment on attachment 329917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329917&action=review

> Source/WebCore/html/canvas/CanvasGradient.cpp:51
> +    // Passing null for canvas ensures that currentColor is treated as black,
> +    // as required by the standard.
>      Color color = parseColorOrCurrentColor(colorString, nullptr /*canvas*/);

The updated comment is good. Even better would be a layout test to both document this behavior and ensure we do not regress it. Do we have an existing test? If not, please write one.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

LayoutTests/imported/w3c/canvas/2d.gradient.object.current.html is checking this and passing.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 330030 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 330030 [details]
Patch

Clearing flags on attachment: 330030

Committed r226220: <https://trac.webkit.org/changeset/226220>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36177424>