Bug 181018

Summary: [RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from RenderTable::addChild to RenderTreeBuilder
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2017-12-19 21:40:53 PST
ssia
Attachments
Patch (11.57 KB, patch)
2017-12-19 21:46 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.54 KB, patch)
2017-12-20 07:17 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-19 21:41:18 PST
<rdar://problem/36148601>
alan
Comment 2 2017-12-19 21:46:13 PST
Created attachment 329896 [details] Patch
Antti Koivisto
Comment 3 2017-12-20 06:16:25 PST
Comment on attachment 329896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329896&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:66 > + auto& parentCandidate = m_tableBuilder->findOrCreateParentForChild(downcast<RenderTableRow>(parent), *child, beforeChild); I added tableBuilder() helper, you can use that (probably also why this doesn't merge).
alan
Comment 4 2017-12-20 07:17:34 PST
Created attachment 329916 [details] Patch
WebKit Commit Bot
Comment 5 2017-12-20 08:53:03 PST
Comment on attachment 329916 [details] Patch Clearing flags on attachment: 329916 Committed r226181: <https://trac.webkit.org/changeset/226181>
WebKit Commit Bot
Comment 6 2017-12-20 08:53:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.