Bug 181000

Summary: ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2017-12-19 14:25:56 PST 
In addition, service worker frame loader client should allow using credentials
Comment 1 youenn fablet 2017-12-19 14:31:53 PST 
Created attachment 329827 [details]
Patch
Comment 2 youenn fablet 2017-12-19 15:15:09 PST 
Created attachment 329838 [details]
Patch
Comment 3 Chris Dumez 2017-12-20 09:05:10 PST 
Comment on attachment 329838 [details]
Patch

Seems fine but it'd be good if Brady or Alex had a look.
Comment 4 Brady Eidson 2017-12-20 14:49:45 PST 
Comment on attachment 329838 [details]
Patch

seems fine-ish
Comment 5 WebKit Commit Bot 2017-12-21 12:19:13 PST 
Comment on attachment 329838 [details]
Patch

Rejecting attachment 329838 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 329838, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in
patching file Source/WebKitLegacy/mac/Misc/WebCache.mm
patching file LayoutTests/imported/w3c/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5791458
Comment 6 youenn fablet 2017-12-21 21:01:11 PST 
Created attachment 330105 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-12-21 21:36:17 PST 
Comment on attachment 330105 [details]
Patch for landing

Clearing flags on attachment: 330105

Committed r226257: <https://trac.webkit.org/changeset/226257>
Comment 8 WebKit Commit Bot 2017-12-21 21:36:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-12-21 21:37:23 PST 
<rdar://problem/36190807>