Bug 180992

Summary: Move first-letter building code to RenderTreeBuilder
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
zalan: review+
patch
none
patch none

Antti Koivisto
Reported 2017-12-19 13:20:20 PST
RenderTreeBuilder should deal with all special case tree mutations.
Attachments
patch (52.50 KB, patch)
2017-12-19 13:25 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (52.50 KB, patch)
2017-12-19 13:47 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (52.92 KB, patch)
2017-12-19 15:18 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-12-19 13:25:50 PST
Created attachment 329803 [details] patch
zalan
Comment 2 2017-12-19 13:30:22 PST
Comment on attachment 329803 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=329803&action=review > Source/WebCore/ChangeLog:8 > + All special case tree building logic should go to RenderTreeBuilder.s awesome extension!
Antti Koivisto
Comment 3 2017-12-19 13:47:48 PST
Created attachment 329809 [details] patch
Antti Koivisto
Comment 4 2017-12-19 15:18:22 PST
Created attachment 329840 [details] patch
WebKit Commit Bot
Comment 5 2017-12-19 17:44:41 PST
Comment on attachment 329840 [details] patch Clearing flags on attachment: 329840 Committed r226168: <https://trac.webkit.org/changeset/226168>
WebKit Commit Bot
Comment 6 2017-12-19 17:44:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-19 17:45:27 PST
<rdar://problem/36145846>
Note You need to log in before you can comment on or make changes to this bug.