Summary: | We forgot to do index masking for in bounds int32 arrays in the FTL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2017-12-19 12:28:56 PST
Created attachment 329792 [details]
patch
Comment on attachment 329792 [details]
patch
r=me.
Comment on attachment 329792 [details] patch Clearing flags on attachment: 329792 Committed r226139: <https://trac.webkit.org/changeset/226139> All reviewed patches have been landed. Closing bug. This introduces 15.4% regression in Octane/crypto. It seems indexing masking cause very large overhead. Can we have a way to alleviate it? |