Bug 180987

Summary: We forgot to do index masking for in bounds int32 arrays in the FTL
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2017-12-19 12:28:56 PST
....
Attachments
patch (1.87 KB, patch)
2017-12-19 12:29 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-12-19 12:29:38 PST
Created attachment 329792 [details] patch
Keith Miller
Comment 2 2017-12-19 12:30:41 PST
Comment on attachment 329792 [details] patch r=me.
WebKit Commit Bot
Comment 3 2017-12-19 13:51:30 PST
Comment on attachment 329792 [details] patch Clearing flags on attachment: 329792 Committed r226139: <https://trac.webkit.org/changeset/226139>
WebKit Commit Bot
Comment 4 2017-12-19 13:51:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-19 13:52:33 PST
<rdar://problem/36139961>
Yusuke Suzuki
Comment 6 2017-12-20 00:25:15 PST
This introduces 15.4% regression in Octane/crypto. It seems indexing masking cause very large overhead. Can we have a way to alleviate it?
Note You need to log in before you can comment on or make changes to this bug.