Bug 180976

Summary: Do not search for service worker registration in case of non HTTP navigation loads
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, dbates, ews-watchlist, ggaren, japhet, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180929
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Fixing spaces none

youenn fablet
Reported 2017-12-19 09:17:30 PST
Do not search for service workers in case of non HTTP main frame navigation loads.
Attachments
Patch (2.18 KB, patch)
2017-12-19 09:18 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.32 KB, patch)
2017-12-19 09:23 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.45 KB, patch)
2017-12-19 15:12 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing spaces (2.17 KB, patch)
2017-12-20 13:30 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-19 09:18:48 PST
Created attachment 329765 [details] Patch
youenn fablet
Comment 2 2017-12-19 09:23:00 PST
Created attachment 329766 [details] Patch
youenn fablet
Comment 3 2017-12-19 15:12:49 PST
Created attachment 329837 [details] Patch
WebKit Commit Bot
Comment 4 2017-12-20 09:22:39 PST
Comment on attachment 329837 [details] Patch Clearing flags on attachment: 329837 Committed r226185: <https://trac.webkit.org/changeset/226185>
WebKit Commit Bot
Comment 5 2017-12-20 09:22:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-20 09:23:27 PST
<rdar://problem/36157322>
Tim Horton
Comment 7 2017-12-20 13:24:08 PST
Comment on attachment 329837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329837&action=review > Source/WebCore/loader/DocumentLoader.cpp:1573 > + auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled() && SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying()); What’s going on with all the weird spaces?
youenn fablet
Comment 8 2017-12-20 13:28:26 PST
Comment on attachment 329837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329837&action=review >> Source/WebCore/loader/DocumentLoader.cpp:1573 >> + auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled() && SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying()); > > What’s going on with all the weird spaces? Will fix it.
youenn fablet
Comment 9 2017-12-20 13:30:35 PST
Reopening to attach new patch.
youenn fablet
Comment 10 2017-12-20 13:30:35 PST
Created attachment 329949 [details] Fixing spaces
WebKit Commit Bot
Comment 11 2017-12-20 13:51:42 PST
Comment on attachment 329949 [details] Fixing spaces Clearing flags on attachment: 329949 Committed r226200: <https://trac.webkit.org/changeset/226200>
WebKit Commit Bot
Comment 12 2017-12-20 13:51:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.