Summary: | Don't convert pasted content to use blob URL in WebKit1 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=178947 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-12-19 01:51:06 PST
Created attachment 329823 [details]
Restores the old behavior
Comment on attachment 329823 [details] Restores the old behavior View in context: https://bugs.webkit.org/attachment.cgi?id=329823&action=review > Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125 > + destinationWebView.get().frameLoadDelegate = delegate.get(); Nit - we usually write using bracket notation (as [destinationWebView setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for the other places in this file) (In reply to Wenson Hsieh from comment #3) > Comment on attachment 329823 [details] > Restores the old behavior > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329823&action=review > > > Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:125 > > + destinationWebView.get().frameLoadDelegate = delegate.get(); > > Nit - we usually write using bracket notation (as [destinationWebView > setFrameLoadDelegate:]), instead of using get() on the RetainPtr (ditto for > the other places in this file) Fixed. Thanks for the review. Committed r226156: <https://trac.webkit.org/changeset/226156> |