Bug 180956

Summary: Web Inspector: InspectorTest.evaluateInPage should return a rejection if an error was thrown
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v2
none
Patch v2 joepeck: review-

Blaze Burg
Reported 2017-12-18 16:13:59 PST
This is definitely what's most convenient when writing tests. async function will turn this into a thrown error that causes everything to blow up rather than silently fail.
Attachments
Patch (6.80 KB, patch)
2017-12-18 16:16 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v2 (20.66 KB, patch)
2017-12-18 16:34 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v2 (6.82 KB, patch)
2017-12-18 16:34 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v2 (20.66 KB, patch)
2017-12-18 16:47 PST, Blaze Burg 		joepeck: review-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-12-18 16:16:51 PST
Created attachment 329704 [details] Patch
Blaze Burg
Comment 2 2017-12-18 16:34:05 PST
Created attachment 329705 [details] Patch v2
Blaze Burg
Comment 3 2017-12-18 16:34:27 PST
Created attachment 329706 [details] Patch v2
Joseph Pecoraro
Comment 4 2017-12-18 16:42:33 PST
Comment on attachment 329706 [details] Patch v2 r=me
Blaze Burg
Comment 5 2017-12-18 16:47:05 PST
Created attachment 329712 [details] Patch v2
Joseph Pecoraro
Comment 6 2017-12-19 15:51:44 PST
r- this appears to be the wrong patch.
Blaze Burg
Comment 7 2017-12-19 16:32:49 PST
Comment on attachment 329706 [details] Patch v2 webkit-patch strikes again...
Joseph Pecoraro
Comment 8 2017-12-19 16:50:55 PST
Comment on attachment 329706 [details] Patch v2 r=me
WebKit Commit Bot
Comment 9 2017-12-19 17:30:01 PST
Comment on attachment 329706 [details] Patch v2 Clearing flags on attachment: 329706 Committed r226163: <https://trac.webkit.org/changeset/226163>
WebKit Commit Bot
Comment 10 2017-12-19 17:30:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-12-19 17:31:21 PST
<rdar://problem/36145581>
Note You need to log in before you can comment on or make changes to this bug.