Bug 180956

Summary: Web Inspector: InspectorTest.evaluateInPage should return a rejection if an error was thrown
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v2
none
Patch v2 joepeck: review-

Description BJ Burg 2017-12-18 16:13:59 PST 
This is definitely what's most convenient when writing tests. async function will turn this into a thrown error that causes everything to blow up rather than silently fail.
Comment 1 BJ Burg 2017-12-18 16:16:51 PST 
Created attachment 329704 [details]
Patch
Comment 2 BJ Burg 2017-12-18 16:34:05 PST 
Created attachment 329705 [details]
Patch v2
Comment 3 BJ Burg 2017-12-18 16:34:27 PST 
Created attachment 329706 [details]
Patch v2
Comment 4 Joseph Pecoraro 2017-12-18 16:42:33 PST 
Comment on attachment 329706 [details]
Patch v2

r=me
Comment 5 BJ Burg 2017-12-18 16:47:05 PST 
Created attachment 329712 [details]
Patch v2
Comment 6 Joseph Pecoraro 2017-12-19 15:51:44 PST 
r- this appears to be the wrong patch.
Comment 7 BJ Burg 2017-12-19 16:32:49 PST 
Comment on attachment 329706 [details]
Patch v2

webkit-patch strikes again...
Comment 8 Joseph Pecoraro 2017-12-19 16:50:55 PST 
Comment on attachment 329706 [details]
Patch v2

r=me
Comment 9 WebKit Commit Bot 2017-12-19 17:30:01 PST 
Comment on attachment 329706 [details]
Patch v2

Clearing flags on attachment: 329706

Committed r226163: <https://trac.webkit.org/changeset/226163>
Comment 10 WebKit Commit Bot 2017-12-19 17:30:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-12-19 17:31:21 PST 
<rdar://problem/36145581>