Bug 180937

Summary: Skip slow jsc tests on embedded platforms
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, clopez, commit-queue, guijemont, lforschler, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Guillaume Emont
Reported 2017-12-18 11:31:57 PST
The tests typeProfiler/deltablue-for-of.js and typeProfiler/getter-richards.js take a very long time in the ftl-no-cjit-type-profiler-force-poly-proto on embedded platform, and thus always timeout. They should be skipped on these platforms.
Attachments
Patch (2.14 KB, patch)
2017-12-18 11:38 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2017-12-18 11:38:41 PST
Created attachment 329657 [details] Patch Patch skipping the tests on all arm and mips architectures.
Adrian Perez
Comment 2 2017-12-20 09:29:30 PST
Comment on attachment 329657 [details] Patch Informally reviewing: r+ This sounds reasonable to me, given that many ARM/MIPS based-devices readily available for development and actually running the tests tend to be SoC targeted to the embedded market which tend to be limited in memory, speed, or both.
WebKit Commit Bot
Comment 3 2017-12-21 07:44:00 PST
Comment on attachment 329657 [details] Patch Clearing flags on attachment: 329657 Committed r226222: <https://trac.webkit.org/changeset/226222>
WebKit Commit Bot
Comment 4 2017-12-21 07:44:02 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-02 12:59:03 PST
<rdar://problem/36260881>
Radar WebKit Bug Importer
Comment 6 2018-01-02 12:59:06 PST
<rdar://problem/36260882>
Saam Barati
Comment 7 2020-03-02 13:23:56 PST
Comment on attachment 329657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329657&action=review > JSTests/typeProfiler/getter-richards.js:1 > +//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end Sorry for the 2 year old comment, but just for posterity, this test is wrong because it disables this from running on arm64
Saam Barati
Comment 8 2020-03-02 14:05:27 PST
(In reply to Saam Barati from comment #7) > Comment on attachment 329657 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329657&action=review > > > JSTests/typeProfiler/getter-richards.js:1 > > +//@ if $buildType == "debug" or $architecture =~ /arm|mips/ then skip else runTypeProfiler end > > Sorry for the 2 year old comment, but just for posterity, this test is wrong > because it disables this from running on arm64 "2 year old comment" => "comment on 2 year old patch"
Note You need to log in before you can comment on or make changes to this bug.