Bug 180925

Summary: [Apple Pay] Only include phonetic name properties in ApplePayPaymentContact when version >= 3
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ews-watchlist, sam, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2017-12-17 21:12:27 PST
[Apple Pay] Only include phonetic name properties in ApplePayPaymentContact when version >= 3
Attachments
Patch (21.56 KB, patch)
2017-12-17 21:16 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (36.92 KB, patch)
2017-12-17 21:33 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (22.66 KB, patch)
2017-12-18 21:18 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-12-17 21:12:58 PST
rdar://problem/35907596
Andy Estes
Comment 2 2017-12-17 21:16:10 PST Comment hidden (obsolete)
EWS Watchlist
Comment 3 2017-12-17 21:18:07 PST Comment hidden (obsolete)
Andy Estes
Comment 4 2017-12-17 21:33:50 PST
Created attachment 329637 [details] Patch
EWS Watchlist
Comment 5 2017-12-17 21:35:17 PST
Attachment 329637 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 6 2017-12-18 13:27:24 PST
Comment on attachment 329637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329637&action=review > Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:188 > - 0F7EB7EF1F95285300F1ABCB /* libtestbmalloc */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; name = libtestbmalloc; path = testbmalloc; sourceTree = BUILT_PRODUCTS_DIR; }; > + 0F7EB7EF1F95285300F1ABCB /* testbmalloc */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = testbmalloc; sourceTree = BUILT_PRODUCTS_DIR; }; I think you got some Xcode crazy here.
Andy Estes
Comment 7 2017-12-18 21:18:13 PST
Created attachment 329740 [details] Patch
EWS Watchlist
Comment 8 2017-12-18 21:20:36 PST
Attachment 329740 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 9 2017-12-18 21:39:30 PST
Comment on attachment 329740 [details] Patch Clearing flags on attachment: 329740 Committed r226098: <https://trac.webkit.org/changeset/226098>
WebKit Commit Bot
Comment 10 2017-12-18 21:39:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.