Bug 180925 – [Apple Pay] Only include phonetic name properties in ApplePayPaymentContact when version >= 3

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

[Apple Pay] Only include phonetic name properties in ApplePayPaymentContact when version >= 3

[Andy Estes]

rdar://problem/35907596

[Andy Estes]

Created attachment 329636 [details]
Patch

[EWS Watchlist]

Attachment 329636 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 329637 [details]
Patch

[EWS Watchlist]

Attachment 329637 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 329637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329637&action=review

> Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:188
> -		0F7EB7EF1F95285300F1ABCB /* libtestbmalloc */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; name = libtestbmalloc; path = testbmalloc; sourceTree = BUILT_PRODUCTS_DIR; };
> +		0F7EB7EF1F95285300F1ABCB /* testbmalloc */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = testbmalloc; sourceTree = BUILT_PRODUCTS_DIR; };

I think you got some Xcode crazy here.

[Andy Estes]

Created attachment 329740 [details]
Patch

[EWS Watchlist]

Attachment 329740 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePaySession.cpp:425:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:158:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 329740 [details]
Patch

Clearing flags on attachment: 329740

Committed r226098: <https://trac.webkit.org/changeset/226098>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.