Bug 18091 – font-size doesn't get animated using -webkit-transition

• Component: CSS
• Status: RESOLVED FIXED

[Benoit Marchant]

See the attached test case

[Benoit Marchant]

Created attachment 20060 [details]
example of the bug

example of the bug

[Dave Hyatt]

Created attachment 23058 [details]
Support font-size animation

[Darin Adler]

Comment on attachment 23058 [details]
Support font-size animation

+    // FIXME: Use with caution.  Only used for blending font sizes when animating.
+    void setFontSize(int size) {
+        FontDescription desc(fontDescription());
+        desc.setSpecifiedSize(size);
+        desc.setComputedSize(size);
+        setFontDescription(desc);
+        font().update(font().fontSelector());
+    }

Since this function is only used through a function pointer, it's not helpful to inline it. So it would be better if this was in a .cpp file instead of the header.

The comment says "caution" which I think is too vague. And it says FIXME without being clear what should be fixed. It would be stronger if this said something more like:

    // Used for blending font sizes when animating.
    // Would be a bad idea to use this in other cases because <reason header>.

r=me, but please consider my comments and consider if you can add a test case

[Dave Hyatt]

You can really only make manual tests for transitions, since we have no testing framework for them. :(

I'll change the function name to setBlendedFontSize and remove the inlining.

[Darin Adler]

http://trac.webkit.org/changeset/35975