Bug 180900

Summary: Web Inspector: Styles Redesign: Command-S should save changes in matching CSS resource
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
timothy: review+
Patch none

Nikita Vasilyev
Reported 2017-12-15 18:53:27 PST
When focused on a CSS rule, Command-S should save the owner CSS resource the same way if we were to edit this CSS in Resources tab. The legacy styles sidebar supported it. <rdar://problem/35648633>
Attachments
Patch (3.35 KB, patch)
2017-12-15 18:57 PST, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2017-12-18 14:30 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-12-15 18:57:29 PST
Created attachment 329555 [details] Patch
Nikita Vasilyev
Comment 2 2017-12-15 19:02:57 PST
This is essentially the same patch as it was for the old styles sidebar in 2015 Bug 150298 - Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file.
Timothy Hatcher
Comment 3 2017-12-18 13:25:14 PST
Comment on attachment 329555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329555&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:407 > + url = pathDirectory + "base64.css"; Why base64.css? data.css? WI.frameResourceManager.mainFrame.mainResource.url - ".html" + "-data.css"?
Nikita Vasilyev
Comment 4 2017-12-18 14:30:15 PST
Created attachment 329684 [details] Patch
WebKit Commit Bot
Comment 5 2017-12-18 15:02:43 PST
Comment on attachment 329684 [details] Patch Clearing flags on attachment: 329684 Committed r226082: <https://trac.webkit.org/changeset/226082>
WebKit Commit Bot
Comment 6 2017-12-18 15:02:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.