Bug 180870

Summary: API test WebKit.WebsiteDataStoreCustomPaths is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180722
Attachments:
Description Flags
Patch
cdumez: review+
Fixed for landing none

Description Ryan Haddad 2017-12-15 10:54:36 PST 
API test WebKit.WebsiteDataStoreCustomPaths is failing on Sierra and High Sierra bots.

FAIL WebKit.WebsiteDataStoreCustomPaths

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:219
Value of: [WKWebsiteDataStore _defaultDataStoreExists]
  Actual: true
Expected: false

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/1789
Comment 1 Ryan Haddad 2017-12-15 10:55:10 PST 
The test started failing after https://trac.webkit.org/changeset/225789/webkit landed, and continues to fail after https://bugs.webkit.org/show_bug.cgi?id=180722
Comment 2 Brady Eidson 2017-12-15 11:36:24 PST 
Created attachment 329502 [details]
Patch
Comment 3 Chris Dumez 2017-12-15 11:38:21 PST 
Comment on attachment 329502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329502&action=review

r=me with suggestion.

> Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:66
> +    send(Messages::WebProcess::EstablishWorkerContextConnectionToStorageProcess { m_serviceWorkerPageID, store, idToUse }, 0);

initialSessionID.value_or(PAL::SessionID::defaultSessionID()) ?
Comment 4 Brady Eidson 2017-12-15 12:13:48 PST 
Created attachment 329505 [details]
Fixed for landing
Comment 5 WebKit Commit Bot 2017-12-15 13:11:57 PST 
Comment on attachment 329505 [details]
Fixed for landing

Clearing flags on attachment: 329505

Committed r225980: <https://trac.webkit.org/changeset/225980>
Comment 6 Radar WebKit Bug Importer 2018-01-02 13:18:24 PST 
<rdar://problem/36261368>