Bug 180856

Summary: Remove unnecessary boolean result of start() functions
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-12-14 18:51:25 PST
Remove unnecessary boolean result of start() functions
Attachments
Patch (14.06 KB, patch)
2017-12-16 08:19 PST, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
Patch (14.07 KB, patch)
2017-12-16 08:39 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (14.75 KB, patch)
2017-12-16 09:04 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-12-16 08:19:03 PST
Created attachment 329574 [details] Patch
Darin Adler
Comment 2 2017-12-16 08:31:01 PST
Comment on attachment 329574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329574&action=review > Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:-70 > - return m_thread; Compiler errors make it clear that we also have to turn the "return true" above into "return".
Yusuke Suzuki
Comment 3 2017-12-16 08:38:29 PST
Comment on attachment 329574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329574&action=review Thanks! >> Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:-70 >> - return m_thread; > > Compiler errors make it clear that we also have to turn the "return true" above into "return". Oops, yeah :)
Yusuke Suzuki
Comment 4 2017-12-16 08:39:42 PST
Created attachment 329575 [details] Patch
Yusuke Suzuki
Comment 5 2017-12-16 09:04:11 PST
Created attachment 329576 [details] Patch
Yusuke Suzuki
Comment 6 2017-12-16 09:54:44 PST
Committed r225998: <https://trac.webkit.org/changeset/225998>
Radar WebKit Bug Importer
Comment 7 2017-12-16 09:55:31 PST
<rdar://problem/36091203>
Note You need to log in before you can comment on or make changes to this bug.