| Summary: | [Web Animations] Use is<> when possible | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2017-12-14 13:08:49 PST
Created attachment 329389 [details]
Patch
Comment on attachment 329389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329389&action=review > Source/WebCore/animation/WebAnimation.cpp:748 > - downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated(); > + if (is<KeyframeEffect>(m_effect)) > + downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState(); Did you intend to make this change? (In reply to Dean Jackson from comment #2) > Comment on attachment 329389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329389&action=review > > > Source/WebCore/animation/WebAnimation.cpp:748 > > - downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated(); > > + if (is<KeyframeEffect>(m_effect)) > > + downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState(); > > Did you intend to make this change? Not with the method change name, will fix in commit. Committed r225929: <https://trac.webkit.org/changeset/225929> |