Summary: | Introduce RenderTreeBuilder | ||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||||||||||||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, rniwa, ryanhaddad, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=180896 | ||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-12-14 10:12:20 PST
r=me! :) Created attachment 329359 [details]
patch
Created attachment 329363 [details]
patch
Comment on attachment 329363 [details] patch Attachment 329363 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5661702 Number of test failures exceeded the failure limit. Created attachment 329370 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 329363 [details] patch Attachment 329363 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5661493 Number of test failures exceeded the failure limit. Created attachment 329371 [details]
Archive of layout-test-results from ews113 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 329372 [details]
patch
Comment on attachment 329372 [details]
patch
This is awesome!
Comment on attachment 329372 [details] patch Attachment 329372 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5662571 Number of test failures exceeded the failure limit. Created attachment 329385 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 329407 [details]
patch
Comment on attachment 329407 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=329407&action=review > Source/WebCore/rendering/RenderTreeBuilder.h:43 > + // This is avoids having to convert all sites that need RenderTreeBuilder in one go. Nit: This avoids? Comment on attachment 329407 [details] patch Attachment 329407 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5666467 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html fast/ruby/rubyDOM-remove-rt-block-1.html webgl/1.0.2/conformance/context/context-release-upon-reload.html Created attachment 329428 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 329469 [details]
patch
Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5670982 Number of test failures exceeded the failure limit. Created attachment 329472 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5671011 Number of test failures exceeded the failure limit. Created attachment 329473 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5671095 Number of test failures exceeded the failure limit. Created attachment 329474 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 329469 [details] patch Attachment 329469 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5671204 Number of test failures exceeded the failure limit. Created attachment 329478 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 329479 [details]
patch
Comment on attachment 329479 [details] patch Attachment 329479 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5671887 New failing tests: webgl/1.0.2/conformance/context/context-release-with-workers.html Created attachment 329483 [details]
Archive of layout-test-results from ews113 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 329479 [details] patch Clearing flags on attachment: 329479 Committed r225969: <https://trac.webkit.org/changeset/225969> All reviewed patches have been landed. Closing bug. Reverted r225969 for reason: This change introduced LayoutTest crashes. Committed r225994: <https://trac.webkit.org/changeset/225994> (In reply to Ryan Haddad from comment #31) > Reverted r225969 for reason: > > This change introduced LayoutTest crashes. > > Committed r225994: <https://trac.webkit.org/changeset/225994> Details and report steps in https://bugs.webkit.org/show_bug.cgi?id=180896 *** Bug 180896 has been marked as a duplicate of this bug. *** oh nooo!!! Created attachment 329572 [details]
patch
Comment on attachment 329572 [details] patch Clearing flags on attachment: 329572 Committed r226007: <https://trac.webkit.org/changeset/226007> All reviewed patches have been landed. Closing bug. |