Bug 180809

Summary: [Readable Streams API] Remove properties tests covered by WPT
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: Tools / TestsAssignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, commit-queue, ews-watchlist, lforschler, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Romain Bellessort
Reported 2017-12-14 06:23:43 PST
Multiple RS API tests are duplicated between WebKit LayoutTests and WPT. To keep things "reviewable", I would suggest not removing too many tests from too many different files at the same time. Therefore, as a first step, I propose removing the duplicated properties tests which are found in WPT streams/readable-byte-stream/properties.js . There tests are very similar and easy to compare, hence we are sure that no test is lost. If this is ok, I could go on and remove other duplicated tests. To keep things "reviewable", I would suggest not
Attachments
Patch (14.37 KB, patch)
2017-12-14 06:41 PST, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2017-12-14 06:41:29 PST
Created attachment 329352 [details] Patch
Romain Bellessort
Comment 2 2017-12-14 06:44:31 PST
Please note that the FIXME in the diff of readable-stream-byob-request.js is not new (it is indicated both as an addition and as a deletion).
WebKit Commit Bot
Comment 3 2017-12-14 09:04:24 PST
Comment on attachment 329352 [details] Patch Clearing flags on attachment: 329352 Committed r225906: <https://trac.webkit.org/changeset/225906>
WebKit Commit Bot
Comment 4 2017-12-14 09:04:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-14 09:05:30 PST
<rdar://problem/36048988>
Note You need to log in before you can comment on or make changes to this bug.