Bug 180800

Summary: WebDriver: add a common way to run tests with pytest
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, clopez, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180420
Bug Depends on:    
Bug Blocks: 180420    
Attachments:
Description Flags
Patch clopez: review+

Carlos Garcia Campos
Reported 2017-12-14 03:18:39 PST
We currently use pytestrunner from wpt for w3c tests and our own code for selenium tests. Using the same code for both would simplify everything, but also allows us to have a custom results recorder to support other test expectations like TIMEOUT.
Attachments
Patch (21.92 KB, patch)
2017-12-14 03:29 PST, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-12-14 03:29:03 PST
Created attachment 329342 [details] Patch
EWS Watchlist
Comment 2 2017-12-14 03:32:01 PST
Attachment 329342 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:149: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:150: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:151: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:152: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'server_config' member [pylint/E1101] [5] Total errors found: 4 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2017-12-14 06:37:51 PST
Committed r225902: <https://trac.webkit.org/changeset/225902>
Radar WebKit Bug Importer
Comment 4 2017-12-14 06:38:18 PST
<rdar://problem/36046936>
Note You need to log in before you can comment on or make changes to this bug.