Bug 180780 – [WPE] WebCrypto should be a public option.

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

On bug 179009 the WebCrypto has been turned into a private option.
On top of that the dependency on libtasn1 and gcrypt > 1.6.0 has been forced even if one doesn't enable web_crypto by default.

I think this is wrong.
ENABLE_WEB_CRYPTO should remain a public option for WPE (at least as long as it is also public one on the GTK port).
Also, when this option is disabled the build dependencies on libtasn1 or gcrypt > 1.6.0 is not needed.

Making our build dependencies soft, makes easier to build WPE en embedded systems.
Please don't raise them more than strictly needed.

Also having public options allows external developers building systems to disable feature without having to dive into our cmake code.
Disabling features when don't needed allows for a lower footprint.
Let's try to keep public the options that make sense.

[Carlos Alberto Lopez Perez]

Created attachment 329283 [details]
Patch

[EWS Watchlist]

Attachment 329283 [details] did not pass style-queue:


ERROR: Source/cmake/OptionsWPE.cmake:86:  One space between command "endif" and its parentheses, should be "endif ("  [whitespace/parentheses] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Alberto Lopez Perez]

Created attachment 329286 [details]
Patch

fix style

[WebKit Commit Bot]

Comment on attachment 329286 [details]
Patch

Clearing flags on attachment: 329286

Committed r225888: <https://trac.webkit.org/changeset/225888>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.