Bug 180771

Summary: Take a value driven approach to how we emit structure checks in TypeCheckHoistingPhase to obviate the need for static_assert guards
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2017-12-13 15:15:54 PST
We can just check the condition we care about instead of knowing the condition to be true on 64 bit.
Attachments
patch (2.55 KB, patch)
2017-12-13 15:17 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-12-13 15:17:49 PST
Created attachment 329266 [details] patch
JF Bastien
Comment 2 2017-12-13 15:33:48 PST
Comment on attachment 329266 [details] patch r=me
WebKit Commit Bot
Comment 3 2017-12-13 16:32:02 PST
Comment on attachment 329266 [details] patch Clearing flags on attachment: 329266 Committed r225880: <https://trac.webkit.org/changeset/225880>
WebKit Commit Bot
Comment 4 2017-12-13 16:32:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-13 16:33:47 PST
<rdar://problem/36035713>
Note You need to log in before you can comment on or make changes to this bug.