Bug 180771

Summary:

Take a value driven approach to how we emit structure checks in TypeCheckHoistingPhase to obviate the need for static_assert guards

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2017-12-13 15:15:54 PST

We can just check the condition we care about instead of knowing the condition to be true on 64 bit.

Comment 1 Saam Barati 2017-12-13 15:17:49 PST

Created attachment 329266 [details]
patch

Comment 2 JF Bastien 2017-12-13 15:33:48 PST

Comment on attachment 329266 [details]
patch

r=me

Comment 3 WebKit Commit Bot 2017-12-13 16:32:02 PST

Comment on attachment 329266 [details]
patch

Clearing flags on attachment: 329266

Committed r225880: <https://trac.webkit.org/changeset/225880>

Comment 4 WebKit Commit Bot 2017-12-13 16:32:03 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2017-12-13 16:33:47 PST

<rdar://problem/36035713>