| Summary: | Only use CookieStorageShim when we aren't using NetworkSession | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, bfulgham, jer.noble, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2017-12-13 13:07:55 PST
Created attachment 329247 [details]
Patch
Comment on attachment 329247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329247&action=review > Source/WebKit/ChangeLog:3 > + Only use CookieStorageShim when we aren't using NetworkSession Don’t we need it on 10.11 for media? (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 329247 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329247&action=review > > > Source/WebKit/ChangeLog:3 > > + Only use CookieStorageShim when we aren't using NetworkSession > > Don’t we need it on 10.11 for media? Yes we do. That's why I enclosed it in !USE(NETWORK_SESSION). Otherwise I would've just removed it. I was unclear. What I meant to ask was, do we have platforms that use network session, but still use in-process media loading? (In reply to Alexey Proskuryakov from comment #4) > I was unclear. What I meant to ask was, do we have platforms that use > network session, but still use in-process media loading? No Comment on attachment 329247 [details]
Patch
Looks reasonable. Keep an eye on legacy bots after landing, please.
|