Bug 180738

Summary:

InferredValue should use IsoSubspace

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch	keith_miller: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none

Description Filip Pizlo 2017-12-12 21:21:48 PST

Patch forthcoming.

Comment 1 Filip Pizlo 2017-12-12 21:24:28 PST

Created attachment 329202 [details]
the patch

Comment 2 Filip Pizlo 2017-12-13 13:19:09 PST

Created attachment 329250 [details]
the patch

Comment 3 Keith Miller 2017-12-13 13:43:00 PST

Comment on attachment 329250 [details]
the patch

r=me.

Comment 4 EWS Watchlist 2017-12-13 14:39:48 PST

Comment on attachment 329250 [details]
the patch

Attachment 329250 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5649442

New failing tests:
webrtc/video-replace-muted-track.html

Comment 5 EWS Watchlist 2017-12-13 14:39:49 PST

Created attachment 329260 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 6 Filip Pizlo 2017-12-13 17:11:08 PST

(In reply to Build Bot from comment #4)
> Comment on attachment 329250 [details]
> the patch
> 
> Attachment 329250 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/5649442
> 
> New failing tests:
> webrtc/video-replace-muted-track.html

Seems totally unrelated.

Comment 7 Filip Pizlo 2017-12-13 17:12:20 PST

Landed in https://trac.webkit.org/changeset/225887/webkit

Comment 8 Radar WebKit Bug Importer 2017-12-13 17:13:19 PST

<rdar://problem/36036823>

Comment 9 David Kilzer (:ddkilzer) 2017-12-14 07:37:08 PST

(In reply to Filip Pizlo from comment #7)
> Landed in https://trac.webkit.org/changeset/225887/webkit

Attempt to fix the build:

https://trac.webkit.org/changeset/225903/webkit

Comment 10 David Kilzer (:ddkilzer) 2017-12-14 07:49:28 PST

(In reply to David Kilzer (:ddkilzer) from comment #9)
> (In reply to Filip Pizlo from comment #7)
> > Landed in https://trac.webkit.org/changeset/225887/webkit
> 
> Attempt to fix the build:
> 
> https://trac.webkit.org/changeset/225903/webkit

The broken builds were on internal iOS hardware (arm64) buildbots.