Summary: | TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this| | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, bugs-noreply, clopez, commit-queue, fpizlo, ggaren, gskachkov, guijemont, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari Technology Preview | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 180764 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Saam Barati
2017-12-12 19:20:15 PST
Created attachment 329194 [details]
patch
Comment on attachment 329194 [details]
patch
r=me
Comment on attachment 329194 [details] patch Clearing flags on attachment: 329194 Committed r225844: <https://trac.webkit.org/changeset/225844> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #4) > Comment on attachment 329194 [details] > patch > > Clearing flags on attachment: 329194 > > Committed r225844: <https://trac.webkit.org/changeset/225844> It seems this did cased like 900 test failures on 32-bit? Results for r225843 (74 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 Results for r225844 (904 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 (In reply to Carlos Alberto Lopez Perez from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 329194 [details] > > patch > > > > Clearing flags on attachment: 329194 > > > > Committed r225844: <https://trac.webkit.org/changeset/225844> > > It seems this did cased like 900 test failures on 32-bit? > > Results for r225843 (74 JSC test failed) > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 > Results for r225844 (904 JSC test failed) > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 Reported in bug 180764 (In reply to Carlos Alberto Lopez Perez from comment #7) > (In reply to Carlos Alberto Lopez Perez from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 329194 [details] > > > patch > > > > > > Clearing flags on attachment: 329194 > > > > > > Committed r225844: <https://trac.webkit.org/changeset/225844> > > > > It seems this did cased like 900 test failures on 32-bit? > > > > Results for r225843 (74 JSC test failed) > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 > > Results for r225844 (904 JSC test failed) > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 > > Reported in bug 180764 Thanks will look in a few. |