Bug 180734

Summary: TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bugs-noreply, clopez, commit-queue, fpizlo, ggaren, gskachkov, guijemont, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 180764    
Bug Blocks:    
Attachments:
Description Flags
patch none

Saam Barati
Reported 2017-12-12 19:20:15 PST
Because |this| can be TDZ. This doesn't happen at a function's call entrypoint, but it can happen at a catch entry point.
Attachments
patch (5.13 KB, patch)
2017-12-12 19:28 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-12-12 19:20:48 PST
<rdar://problem/35640547>
Saam Barati
Comment 2 2017-12-12 19:28:47 PST
Created attachment 329194 [details] patch
Yusuke Suzuki
Comment 3 2017-12-13 00:25:28 PST
Comment on attachment 329194 [details] patch r=me
WebKit Commit Bot
Comment 4 2017-12-13 09:19:27 PST
Comment on attachment 329194 [details] patch Clearing flags on attachment: 329194 Committed r225844: <https://trac.webkit.org/changeset/225844>
WebKit Commit Bot
Comment 5 2017-12-13 09:19:29 PST
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 6 2017-12-13 11:54:34 PST
(In reply to WebKit Commit Bot from comment #4) > Comment on attachment 329194 [details] > patch > > Clearing flags on attachment: 329194 > > Committed r225844: <https://trac.webkit.org/changeset/225844> It seems this did cased like 900 test failures on 32-bit? Results for r225843 (74 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 Results for r225844 (904 JSC test failed) https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268
Carlos Alberto Lopez Perez
Comment 7 2017-12-13 12:06:36 PST
(In reply to Carlos Alberto Lopez Perez from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 329194 [details] > > patch > > > > Clearing flags on attachment: 329194 > > > > Committed r225844: <https://trac.webkit.org/changeset/225844> > > It seems this did cased like 900 test failures on 32-bit? > > Results for r225843 (74 JSC test failed) > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 > Results for r225844 (904 JSC test failed) > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 Reported in bug 180764
Saam Barati
Comment 8 2017-12-13 12:25:15 PST
(In reply to Carlos Alberto Lopez Perez from comment #7) > (In reply to Carlos Alberto Lopez Perez from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 329194 [details] > > > patch > > > > > > Clearing flags on attachment: 329194 > > > > > > Committed r225844: <https://trac.webkit.org/changeset/225844> > > > > It seems this did cased like 900 test failures on 32-bit? > > > > Results for r225843 (74 JSC test failed) > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5267 > > Results for r225844 (904 JSC test failed) > > https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/5268 > > Reported in bug 180764 Thanks will look in a few.
Saam Barati
Comment 9 2017-12-13 12:48:01 PST
Fixed in: https://trac.webkit.org/changeset/225865/webkit
Note You need to log in before you can comment on or make changes to this bug.