Bug 180726

Summary: Unify some WebGL sources
Product: WebKit Reporter: Dean Jackson <dino>
Component: CanvasAssignee: Dean Jackson <dino>
Status: REOPENED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+, commit-queue: commit-queue-

Dean Jackson
Reported 2017-12-12 16:31:50 PST
Unify some WebGL sources
Attachments
Patch (35.62 KB, patch)
2017-12-12 16:33 PST, Dean Jackson 		dino: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2017-12-12 16:33:49 PST
Created attachment 329177 [details] Patch
WebKit Commit Bot
Comment 2 2017-12-12 16:35:29 PST
Comment on attachment 329177 [details] Patch Rejecting attachment 329177 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 329177, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Keith, weeks ago found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/5637991
Dean Jackson
Comment 3 2017-12-12 19:52:02 PST
Committed r225836: <https://trac.webkit.org/changeset/225836>
Radar WebKit Bug Importer
Comment 4 2017-12-12 19:53:43 PST
<rdar://problem/36012577>
Ryan Haddad
Comment 5 2017-12-13 10:31:00 PST
As EWS predicted, this change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/6546/steps/compile-webkit/logs/stdio
Ryan Haddad
Comment 6 2017-12-13 10:36:30 PST
Reverted r225836 for reason: Broke the Windows build. Committed r225854: <https://trac.webkit.org/changeset/225854>
Note You need to log in before you can comment on or make changes to this bug.