Bug 180725

Summary: We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
msaboff: review+
patch for landing none

Description Saam Barati 2017-12-12 16:27:43 PST 
...
Comment 1 Saam Barati 2017-12-12 16:28:12 PST 
<rdar://problem/35970511>
Comment 2 Saam Barati 2017-12-12 16:30:58 PST 
Created attachment 329176 [details]
patch
Comment 3 Michael Saboff 2017-12-12 16:33:35 PST 
Comment on attachment 329176 [details]
patch

r=me
Comment 4 Mark Lam 2017-12-12 16:34:52 PST 
Comment on attachment 329176 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329176&action=review

> JSTests/ChangeLog:3
> +        We need model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize

/need model/need to model/

> Source/JavaScriptCore/ChangeLog:3
> +        We need model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize

/need model/need to model/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:123
> +        auto readSpreadOfPhanomCreateRest = [&] (Node* spread) {

typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:138
> +                        readSpreadOfPhanomCreateRest(child);

typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:184
> +                    readSpreadOfPhanomCreateRest(m_node->argumentsChild().node());

typo: /readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/

> Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h:208
> +                readSpreadOfPhanomCreateRest(m_node);

/readSpreadOfPhanomCreateRest/readSpreadOfPhantomCreateRest/
Comment 5 Saam Barati 2017-12-12 16:37:35 PST 
Created attachment 329178 [details]
patch for landing
Comment 6 WebKit Commit Bot 2017-12-12 19:04:26 PST 
Comment on attachment 329178 [details]
patch for landing

Clearing flags on attachment: 329178

Committed r225834: <https://trac.webkit.org/changeset/225834>
Comment 7 WebKit Commit Bot 2017-12-12 19:04:28 PST 
All reviewed patches have been landed.  Closing bug.