Bug 180699

Summary: getUserMedia is resolving before the document knows it is capturing
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Rebasing
none
Patch for landing none

Description youenn fablet 2017-12-12 09:13:27 PST 
Sometimes getUserMedia promise will be resolved and autoplay will not be disabled as the promise resolves before the stream is producing data and the document knows it is capturing.
We may want to delay promise resolution until the stream is ready to produce data.
Comment 1 youenn fablet 2017-12-12 10:09:51 PST 
Created attachment 329119 [details]
Patch
Comment 2 youenn fablet 2017-12-12 11:19:12 PST 
Created attachment 329130 [details]
Patch
Comment 3 youenn fablet 2017-12-12 13:38:35 PST 
Created attachment 329148 [details]
Rebasing
Comment 4 Eric Carlson 2017-12-12 15:12:46 PST 
Comment on attachment 329148 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=329148&action=review

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:260
> +    {

Nit: indentation.
Comment 5 youenn fablet 2017-12-12 15:17:33 PST 
Created attachment 329166 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-12-12 17:39:39 PST 
Comment on attachment 329166 [details]
Patch for landing

Clearing flags on attachment: 329166

Committed r225828: <https://trac.webkit.org/changeset/225828>
Comment 7 WebKit Commit Bot 2017-12-12 17:39:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-12 17:40:32 PST 
<rdar://problem/36010366>