Bug 180697

Summary: Make ServiceWorkers follow the DEFAULT_EXPERIMENTAL_FEATURES_ENABLED flag on Mac
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ggaren, jlewis3, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180700
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-12-12 09:03:46 PST
As a first step towards activating service worker everywhere, make Service Worker experimental flag on by default.
Attachments
Patch (1.20 KB, patch)
2017-12-12 09:04 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2017-12-12 09:48 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2017-12-12 10:23 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-12 09:04:26 PST
Created attachment 329115 [details] Patch
Chris Dumez
Comment 2 2017-12-12 09:11:26 PST
Comment on attachment 329115 [details] Patch I am unclear if this enables the feature on iOS or not. I think we'd want to hold off on iOS a bit until we do some basic testing.
Brady Eidson
Comment 3 2017-12-12 09:28:45 PST
(In reply to Chris Dumez from comment #2) > Comment on attachment 329115 [details] > Patch > > I am unclear if this enables the feature on iOS or not. I think we'd want to > hold off on iOS a bit until we do some basic testing. Right. That's the reason why I hadn't done this yet (e.g resolve the radar) because I'm waiting on input on how to use the yaml to be Mac only.
Brady Eidson
Comment 4 2017-12-12 09:29:05 PST
Comment on attachment 329115 [details] Patch Gotta do this differently
Brady Eidson
Comment 5 2017-12-12 09:29:43 PST
*** Bug 180700 has been marked as a duplicate of this bug. ***
Brady Eidson
Comment 6 2017-12-12 09:48:47 PST
Created attachment 329118 [details] Patch
Chris Dumez
Comment 7 2017-12-12 09:50:24 PST
Comment on attachment 329118 [details] Patch r=me assuming iOS EWS is happy.
Brady Eidson
Comment 8 2017-12-12 10:16:57 PST
It's no good, but I have a good fix.
Brady Eidson
Comment 9 2017-12-12 10:23:37 PST
Created attachment 329123 [details] Patch
WebKit Commit Bot
Comment 10 2017-12-12 10:48:17 PST
Comment on attachment 329123 [details] Patch Clearing flags on attachment: 329123 Committed r225789: <https://trac.webkit.org/changeset/225789>
WebKit Commit Bot
Comment 11 2017-12-12 10:48:19 PST
All reviewed patches have been landed. Closing bug.
Brady Eidson
Comment 12 2017-12-12 10:53:21 PST
<rdar://problem/35978311>
Matt Lewis
Comment 13 2017-12-12 14:04:43 PST
This caused multiple API failures on all macOS platforms: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/6953/steps/run-api-tests/logs/stdio Build: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/6953/steps/run-api-tests/logs/stdio The failing tests: WKProcessPool.InitialWarmedProcessUsed Failure: FAIL WKProcessPool.InitialWarmedProcessUsed /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:51 Value of: static_cast<size_t>(1) Actual: 1 Expected: [pool _webProcessCount] Which is: 2 WebKit.WebsiteDataStoreCustomPaths FAIL WebKit.WebsiteDataStoreCustomPaths /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:219 Value of: [WKWebsiteDataStore _defaultDataStoreExists] Actual: true Expected: false The test passed before this patch and now fail consistently
Matt Lewis
Comment 14 2017-12-12 15:11:40 PST
New bug for the failures and the fix: https://bugs.webkit.org/show_bug.cgi?id=180722
Note You need to log in before you can comment on or make changes to this bug.