Summary: | Symbol not found: __ZN3WTF8LockBase10unlockSlowEv | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, joepeck, mitz, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=180495 | ||||||
Attachments: |
|
Description
Devin Rousso
2017-12-11 23:39:18 PST
Looks like system macOS 10.13.2 Safari needs this symbol: $ c++filt __ZN3WTF8LockBase10unlockSlowEv WTF::LockBase::unlockSlow() Typically we add back something like this into: WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm I don't know the full list of symbols we need to add back. Probably a few of these, which just moved from WTF::LockBase to WTF::Lock. WTF_EXPORT_PRIVATE void lockSlow(); WTF_EXPORT_PRIVATE void unlockSlow(); WTF_EXPORT_PRIVATE void unlockFairlySlow(); WTF_EXPORT_PRIVATE void safepointSlow(); Created attachment 329096 [details]
[PATCH] Proposed Fix
Comment on attachment 329096 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329096&action=review > Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:132 > +#if PLATFORM(MAC) Not sure if it is worth adding a restriction here, such as: && __MAC_OS_X_VERSION_MIN_REQUIRED < 101340 But reviewers let me know if you think that would be worth doing. Comment on attachment 329096 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=329096&action=review >> Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm:132 >> +#if PLATFORM(MAC) > > Not sure if it is worth adding a restriction here, such as: > > && __MAC_OS_X_VERSION_MIN_REQUIRED < 101340 > > But reviewers let me know if you think that would be worth doing. I think this restriction is useful since it can be a marker for dropping this in the future. Adding `FIXME` comment is also nice. |