Bug 180660

Summary: [WinCairo] Enable running sharded tests
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: Tools / TestsAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, bfulgham, commit-queue, don.olmstead, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
achristensen: review+, achristensen: commit-queue-
fixed none

Description Basuke Suzuki 2017-12-11 10:39:18 PST
Sharding haven't worked for WinCairo on native Windows by failing separation if basename and dirname.
Comment 1 Basuke Suzuki 2017-12-11 11:34:39 PST
Created attachment 329006 [details]
patch
Comment 2 Alex Christensen 2017-12-11 15:53:53 PST
Comment on attachment 329006 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329006&action=review

> Tools/Scripts/webkitpy/port/win.py:440
> +    # FIXME I don't see why base Port depends on UNIX separator, but I'm afraid breaking other environment
> +    TEST_PATH_SEPARATOR = os.sep

I don't think this is a good comment.  If this is necessary, then it's necessary.
Comment 3 Basuke Suzuki 2017-12-11 20:02:21 PST
Created attachment 329081 [details]
fixed

remove comment as reviewd
Comment 4 EWS Watchlist 2017-12-11 20:02:43 PST
Comment on attachment 329081 [details]
fixed

Rejecting attachment 329081 [details] from commit-queue.

Basuke.Suzuki@sony.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2017-12-11 20:54:28 PST
Comment on attachment 329081 [details]
fixed

Clearing flags on attachment: 329081

Committed r225770: <https://trac.webkit.org/changeset/225770>
Comment 6 WebKit Commit Bot 2017-12-11 20:54:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-11 20:55:25 PST
<rdar://problem/35986463>