Sharding haven't worked for WinCairo on native Windows by failing separation if basename and dirname.
Created attachment 329006 [details] patch
Comment on attachment 329006 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=329006&action=review > Tools/Scripts/webkitpy/port/win.py:440 > + # FIXME I don't see why base Port depends on UNIX separator, but I'm afraid breaking other environment > + TEST_PATH_SEPARATOR = os.sep I don't think this is a good comment. If this is necessary, then it's necessary.
Created attachment 329081 [details] fixed remove comment as reviewd
Comment on attachment 329081 [details] fixed Rejecting attachment 329081 [details] from commit-queue. Basuke.Suzuki@sony.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 329081 [details] fixed Clearing flags on attachment: 329081 Committed r225770: <https://trac.webkit.org/changeset/225770>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35986463>