Bug 180660 - [WinCairo] Enable running sharded tests
Summary: [WinCairo] Enable running sharded tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
Keywords: InRadar
Depends on:
Reported: 2017-12-11 10:39 PST by Basuke Suzuki
Modified: 2017-12-11 20:55 PST (History)
9 users (show)

See Also:

patch (1.42 KB, patch)
2017-12-11 11:34 PST, Basuke Suzuki
achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
fixed (1.31 KB, patch)
2017-12-11 20:02 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-12-11 10:39:18 PST
Sharding haven't worked for WinCairo on native Windows by failing separation if basename and dirname.
Comment 1 Basuke Suzuki 2017-12-11 11:34:39 PST
Created attachment 329006 [details]
Comment 2 Alex Christensen 2017-12-11 15:53:53 PST
Comment on attachment 329006 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=329006&action=review

> Tools/Scripts/webkitpy/port/win.py:440
> +    # FIXME I don't see why base Port depends on UNIX separator, but I'm afraid breaking other environment
> +    TEST_PATH_SEPARATOR = os.sep

I don't think this is a good comment.  If this is necessary, then it's necessary.
Comment 3 Basuke Suzuki 2017-12-11 20:02:21 PST
Created attachment 329081 [details]

remove comment as reviewd
Comment 4 EWS Watchlist 2017-12-11 20:02:43 PST
Comment on attachment 329081 [details]

Rejecting attachment 329081 [details] from commit-queue.

Basuke.Suzuki@sony.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2017-12-11 20:54:28 PST
Comment on attachment 329081 [details]

Clearing flags on attachment: 329081

Committed r225770: <https://trac.webkit.org/changeset/225770>
Comment 6 WebKit Commit Bot 2017-12-11 20:54:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-12-11 20:55:25 PST