Summary: | StyleBench improvements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, ggaren, lforschler, rniwa, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-12-11 06:11:29 PST
Created attachment 328964 [details]
patch
Created attachment 328967 [details]
patch
Created attachment 328969 [details]
patch
Comment on attachment 328969 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=328969&action=review r=me > PerformanceTests/ChangeLog:8 > + - Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths. Do we need a dedicated subtest to cover this pathology, since it showed a performance difference between Safari and Firefox? > Do we need a dedicated subtest to cover this pathology, since it showed a
> performance difference between Safari and Firefox?
Probably not, it was just a mistake in the test. It is covered by the positional pseudo class test along with other similar cases (we lose to Firefox badly there).
Comment on attachment 328969 [details] patch Clearing flags on attachment: 328969 Committed r225752: <https://trac.webkit.org/changeset/225752> All reviewed patches have been landed. Closing bug. |