|Product:||WebKit||Reporter:||Antti Koivisto <koivisto>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||cdumez, commit-queue, ews-watchlist, ggaren, lforschler, rniwa, simon.fraser, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Antti Koivisto 2017-12-11 06:11:29 PST
Add id selectors etc.
Comment 4 Geoffrey Garen 2017-12-11 11:15:02 PST
Comment on attachment 328969 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=328969&action=review r=me > PerformanceTests/ChangeLog:8 > + - Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths. Do we need a dedicated subtest to cover this pathology, since it showed a performance difference between Safari and Firefox?
Comment 5 Antti Koivisto 2017-12-11 11:20:07 PST
> Do we need a dedicated subtest to cover this pathology, since it showed a > performance difference between Safari and Firefox? Probably not, it was just a mistake in the test. It is covered by the positional pseudo class test along with other similar cases (we lose to Firefox badly there).
Comment 6 WebKit Commit Bot 2017-12-11 11:41:49 PST
Comment on attachment 328969 [details] patch Clearing flags on attachment: 328969 Committed r225752: <https://trac.webkit.org/changeset/225752>
Comment 7 WebKit Commit Bot 2017-12-11 11:41:51 PST
All reviewed patches have been landed. Closing bug.