Bug 180646

Summary: StyleBench improvements
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, ggaren, lforschler, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Antti Koivisto 2017-12-11 06:11:29 PST
Add id selectors etc.
Comment 1 Antti Koivisto 2017-12-11 06:22:37 PST
Created attachment 328964 [details]
patch
Comment 2 Antti Koivisto 2017-12-11 07:17:28 PST
Created attachment 328967 [details]
patch
Comment 3 Antti Koivisto 2017-12-11 07:36:50 PST
Created attachment 328969 [details]
patch
Comment 4 Geoffrey Garen 2017-12-11 11:15:02 PST
Comment on attachment 328969 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328969&action=review

r=me

> PerformanceTests/ChangeLog:8
> +        - Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths.

Do we need a dedicated subtest to cover this pathology, since it showed a performance difference between Safari and Firefox?
Comment 5 Antti Koivisto 2017-12-11 11:20:07 PST
> Do we need a dedicated subtest to cover this pathology, since it showed a
> performance difference between Safari and Firefox?

Probably not, it was just a mistake in the test. It is covered by the positional pseudo class test along with other similar cases (we lose to Firefox badly there).
Comment 6 WebKit Commit Bot 2017-12-11 11:41:49 PST
Comment on attachment 328969 [details]
patch

Clearing flags on attachment: 328969

Committed r225752: <https://trac.webkit.org/changeset/225752>
Comment 7 WebKit Commit Bot 2017-12-11 11:41:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-11 11:42:30 PST
<rdar://problem/35973513>