RESOLVED FIXED180646
StyleBench improvements 
https://bugs.webkit.org/show_bug.cgi?id=180646
Summary StyleBench improvements
Antti Koivisto
Reported 2017-12-11 06:11:29 PST
Add id selectors etc.
Attachments
patch (6.29 KB, patch)
2017-12-11 06:22 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (8.69 KB, patch)
2017-12-11 07:17 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (8.97 KB, patch)
2017-12-11 07:36 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-12-11 06:22:37 PST
Created attachment 328964 [details] patch
Antti Koivisto
Comment 2 2017-12-11 07:17:28 PST
Created attachment 328967 [details] patch
Antti Koivisto
Comment 3 2017-12-11 07:36:50 PST
Created attachment 328969 [details] patch
Geoffrey Garen
Comment 4 2017-12-11 11:15:02 PST
Comment on attachment 328969 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=328969&action=review r=me > PerformanceTests/ChangeLog:8 > + - Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths. Do we need a dedicated subtest to cover this pathology, since it showed a performance difference between Safari and Firefox?
Antti Koivisto
Comment 5 2017-12-11 11:20:07 PST
> Do we need a dedicated subtest to cover this pathology, since it showed a > performance difference between Safari and Firefox? Probably not, it was just a mistake in the test. It is covered by the positional pseudo class test along with other similar cases (we lose to Firefox badly there).
WebKit Commit Bot
Comment 6 2017-12-11 11:41:49 PST
Comment on attachment 328969 [details] patch Clearing flags on attachment: 328969 Committed r225752: <https://trac.webkit.org/changeset/225752>
WebKit Commit Bot
Comment 7 2017-12-11 11:41:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-12-11 11:42:30 PST
<rdar://problem/35973513>
Note You need to log in before you can comment on or make changes to this bug.