Bug 180646 - StyleBench improvements
Summary: StyleBench improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-11 06:11 PST by Antti Koivisto
Modified: 2017-12-11 11:42 PST (History)
8 users (show)

See Also:

Attachments
patch (6.29 KB, patch)
2017-12-11 06:22 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (8.69 KB, patch)
2017-12-11 07:17 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (8.97 KB, patch)
2017-12-11 07:36 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-12-11 06:11:29 PST 
Add id selectors etc.
Comment 1 Antti Koivisto 2017-12-11 06:22:37 PST 
Created attachment 328964 [details]
patch
Comment 2 Antti Koivisto 2017-12-11 07:17:28 PST 
Created attachment 328967 [details]
patch
Comment 3 Antti Koivisto 2017-12-11 07:36:50 PST 
Created attachment 328969 [details]
patch
Comment 4 Geoffrey Garen 2017-12-11 11:15:02 PST 
Comment on attachment 328969 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328969&action=review

r=me

> PerformanceTests/ChangeLog:8
> +        - Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths.

Do we need a dedicated subtest to cover this pathology, since it showed a performance difference between Safari and Firefox?
Comment 5 Antti Koivisto 2017-12-11 11:20:07 PST 
> Do we need a dedicated subtest to cover this pathology, since it showed a
> performance difference between Safari and Firefox?

Probably not, it was just a mistake in the test. It is covered by the positional pseudo class test along with other similar cases (we lose to Firefox badly there).
Comment 6 WebKit Commit Bot 2017-12-11 11:41:49 PST 
Comment on attachment 328969 [details]
patch

Clearing flags on attachment: 328969

Committed r225752: <https://trac.webkit.org/changeset/225752>
Comment 7 WebKit Commit Bot 2017-12-11 11:41:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-11 11:42:30 PST 
<rdar://problem/35973513>