Bug 180640 – [Win] Build with -DUCHAR_TYPE=wchar_t for the stopgap for UChar change of ICU 59

• Component: WebKit Misc.
• Status: RESOLVED WONTFIX

[Fujii Hironori]

[Win] Build with -DUCHAR_TYPE=wchar_t for the stopgap for UChar change of ICU 59

http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac

> Unsigned 16-bit integer. Starting with ICU 59, C++ API uses
> char16_t directly, while C API continues to use UChar.
> 
> UChar is configurable by defining the macro UCHAR_TYPE on the
> preprocessor or compiler command line: -DUCHAR_TYPE=uint16_t or
> -DUCHAR_TYPE=wchar_t (if U_SIZEOF_WCHAR_T==2) etc. (The
> UCHAR_TYPE can also be #defined earlier in this file, for outside
> the ICU library code.) This is for transitional use from
> application code that uses uint16_t or wchar_t for UTF-16.
> 
> The default is UChar=char16_t.

[Fujii Hironori]

Following compilation error are reported with ICU 59.

> C:\webkit\gb\Source\WTF\wtf/text/StringHasher.h(253): error C2535: 'UChar WTF::StringHasher::defaultConverter(UChar)': member function already defined or declared
> C:\webkit\gb\Source\WTF\wtf/text/StringHasher.h(237): note: see declaration of 'WTF::StringHasher::defaultConverter'

Becuase UChar and char16_t are identical.

>    237	    static constexpr UChar defaultConverter(UChar character)
>    238	    {
>    239	        return character;
>    240	    }
(...)
>    252	    static constexpr UChar defaultConverter(char16_t character)
>    253	    {
>    254	        return character;
>    255	    }

[Fujii Hironori]

Created attachment 328957 [details]
Patch

[Fujii Hironori]

That code was remove in Bug 180656.
Closed this bug.