Bug 180626

Summary: Web Inspector: support async setup() and async teardown() in AsyncTestSuite
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix none

Blaze Burg
Reported 2017-12-09 13:47:56 PST
I found a use for this.
Attachments
Proposed Fix (14.90 KB, patch)
2017-12-09 13:52 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (14.81 KB, patch)
2017-12-12 14:07 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-12-09 13:52:45 PST
Created attachment 328916 [details] Proposed Fix
Timothy Hatcher
Comment 2 2017-12-11 15:07:23 PST
Comment on attachment 328916 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=328916&action=review > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:142 > + if (testcase.test[Symbol.toStringTag] === "AsyncFunction") So if test case.test() is async, then we assume testcase.setup() is too? Or should this test testcase.setup[Symbol.toStringTag]? Assert here one way or another? > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:163 > + if (testcase.test[Symbol.toStringTag] === "AsyncFunction") Ditto for testcase.teardown().
Blaze Burg
Comment 3 2017-12-11 21:45:02 PST
(In reply to Timothy Hatcher from comment #2) > Comment on attachment 328916 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328916&action=review > > > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:142 > > + if (testcase.test[Symbol.toStringTag] === "AsyncFunction") > > So if test case.test() is async, then we assume testcase.setup() is too? Or > should this test testcase.setup[Symbol.toStringTag]? Assert here one way or > another? > > > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:163 > > + if (testcase.test[Symbol.toStringTag] === "AsyncFunction") > > Ditto for testcase.teardown(). Ooh, copypasta. It's supposed to be .setup and .teardown.
Blaze Burg
Comment 4 2017-12-12 14:07:07 PST
Created attachment 329152 [details] Proposed Fix
WebKit Commit Bot
Comment 5 2017-12-12 16:31:18 PST
Comment on attachment 329152 [details] Proposed Fix Clearing flags on attachment: 329152 Committed r225820: <https://trac.webkit.org/changeset/225820>
WebKit Commit Bot
Comment 6 2017-12-12 16:31:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-12 16:32:44 PST
<rdar://problem/36008686>
Note You need to log in before you can comment on or make changes to this bug.