Bug 180624

Summary: [WTF] Remove RELAXED_CONSTEXPR
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, jfbastien, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2017-12-09 12:26:13 PST
[WTF] Remove RELAXED_CONSTEXPR
Attachments
Patch (6.35 KB, patch)
2017-12-09 12:27 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-12-09 12:27:42 PST
Created attachment 328913 [details] Patch
Yusuke Suzuki
Comment 2 2017-12-09 12:28:28 PST
I believe it works in VC++ 2017. Watching on EWS.
EWS Watchlist
Comment 3 2017-12-09 12:29:34 PST
Attachment 328913 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Expected.h:485: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:491: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:494: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:554: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
JF Bastien
Comment 4 2017-12-09 13:00:23 PST
Comment on attachment 328913 [details] Patch 🎉 =me r=me
Yusuke Suzuki
Comment 5 2017-12-09 13:21:53 PST
Comment on attachment 328913 [details] Patch Yay, EWS becomes green. I'll land this :)
WebKit Commit Bot
Comment 6 2017-12-09 13:42:06 PST
Comment on attachment 328913 [details] Patch Clearing flags on attachment: 328913 Committed r225728: <https://trac.webkit.org/changeset/225728>
WebKit Commit Bot
Comment 7 2017-12-09 13:42:07 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-12-09 13:43:36 PST
<rdar://problem/35953465>
Note You need to log in before you can comment on or make changes to this bug.