Bug 180615

Summary:

ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2017-12-08 16:23:21 PST

ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL, similarly to what we do for Window.
This allows a getter to be fallback to the global object as ThisValue when the cast of the ThisValue to the expected type fails.

Comment 1 Chris Dumez 2017-12-08 16:24:21 PST

Created attachment 328883 [details]
Patch

Comment 2 Chris Dumez 2017-12-08 16:26:34 PST

Created attachment 328884 [details]
Patch

Comment 3 WebKit Commit Bot 2017-12-08 19:44:36 PST

Comment on attachment 328884 [details]
Patch

Clearing flags on attachment: 328884

Committed r225718: <https://trac.webkit.org/changeset/225718>

Comment 4 WebKit Commit Bot 2017-12-08 19:44:38 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2017-12-08 19:45:24 PST

<rdar://problem/35949192>