Bug 180615

Summary: ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-12-08 16:23:21 PST
ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL, similarly to what we do for Window. This allows a getter to be fallback to the global object as ThisValue when the cast of the ThisValue to the expected type fails.
Attachments
Patch (6.96 KB, patch)
2017-12-08 16:24 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.73 KB, patch)
2017-12-08 16:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-12-08 16:24:21 PST
Created attachment 328883 [details] Patch
Chris Dumez
Comment 2 2017-12-08 16:26:34 PST
Created attachment 328884 [details] Patch
WebKit Commit Bot
Comment 3 2017-12-08 19:44:36 PST
Comment on attachment 328884 [details] Patch Clearing flags on attachment: 328884 Committed r225718: <https://trac.webkit.org/changeset/225718>
WebKit Commit Bot
Comment 4 2017-12-08 19:44:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-08 19:45:24 PST
<rdar://problem/35949192>
Note You need to log in before you can comment on or make changes to this bug.