Bug 180613

Summary: WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, ggaren, sam, thorton
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
Add _alwaysShows{Horizontal,Vertical}Scroller properties ggaren: review+

mitz
Reported 2017-12-08 15:56:39 PST
WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Attachments
WIP (20.61 KB, patch)
2017-12-16 00:29 PST, mitz 		no flags
DetailsFormatted DiffDiff
WIP (20.59 KB, patch)
2017-12-16 00:35 PST, mitz 		no flags
DetailsFormatted DiffDiff
Add _alwaysShows{Horizontal,Vertical}Scroller properties (35.85 KB, patch)
2017-12-16 09:13 PST, mitz 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2017-12-08 15:58:40 PST
<rdar://problem/35946124>
mitz
Comment 2 2017-12-16 00:29:15 PST
Created attachment 329566 [details] WIP
EWS Watchlist
Comment 3 2017-12-16 00:31:21 PST
Attachment 329566 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:4928: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:4941: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 3 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 4 2017-12-16 00:35:23 PST
Created attachment 329568 [details] WIP
EWS Watchlist
Comment 5 2017-12-16 00:38:42 PST
Attachment 329568 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 6 2017-12-16 09:13:45 PST
Created attachment 329578 [details] Add _alwaysShows{Horizontal,Vertical}Scroller properties
EWS Watchlist
Comment 7 2017-12-16 09:16:16 PST
Attachment 329578 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 8 2017-12-16 12:51:20 PST
Comment on attachment 329578 [details] Add _alwaysShows{Horizontal,Vertical}Scroller properties r=me
mitz
Comment 9 2017-12-16 12:57:24 PST
Fixed in <https://trac.webkit.org/r226008>.
Note You need to log in before you can comment on or make changes to this bug.