Bug 180613

Summary: WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, ggaren, sam, thorton
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
Add _alwaysShows{Horizontal,Vertical}Scroller properties ggaren: review+

Description mitz 2017-12-08 15:56:39 PST
WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
Comment 1 mitz 2017-12-08 15:58:40 PST
<rdar://problem/35946124>
Comment 2 mitz 2017-12-16 00:29:15 PST
Created attachment 329566 [details]
WIP
Comment 3 EWS Watchlist 2017-12-16 00:31:21 PST
Attachment 329566 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:4928:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:4941:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 mitz 2017-12-16 00:35:23 PST
Created attachment 329568 [details]
WIP
Comment 5 EWS Watchlist 2017-12-16 00:38:42 PST
Attachment 329568 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 mitz 2017-12-16 09:13:45 PST
Created attachment 329578 [details]
Add _alwaysShows{Horizontal,Vertical}Scroller properties
Comment 7 EWS Watchlist 2017-12-16 09:16:16 PST
Attachment 329578 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:327:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Geoffrey Garen 2017-12-16 12:51:20 PST
Comment on attachment 329578 [details]
Add _alwaysShows{Horizontal,Vertical}Scroller properties

r=me
Comment 9 mitz 2017-12-16 12:57:24 PST
Fixed in <https://trac.webkit.org/r226008>.