Bug 18061

Summary:

PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets

Product:

WebKit

Reporter:

Jasper Bryant-Greene <jasper>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alp

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

URL:

http://acid3.acidtests.org/

Attachments:

Description	Flags
prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets	alp: review+

Jasper Bryant-Greene

Reported 2008-03-25 02:04:46 PDT

The attached patch adds a missing clampNegativeToZero() call to stop PlatformScrollBarGtk from allocating negative width and/or height for widgets. This stops massive barfage of warnings like this on, for example, the Acid3 test: (juniper:12951): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -15 and height 15

Attachments
prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets (1.52 KB, patch) 2008-03-25 02:05 PDT, Jasper Bryant-Greene	alp: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jasper Bryant-Greene

Comment 1 2008-03-25 02:05:32 PDT

Created attachment 20024 [details] prevent PlatformScrollBarGtk from allocating negative width and/or height for widgets

Alp Toker

Comment 2 2008-03-28 11:27:10 PDT

Landed in r31399. Including the bug URL/subject in the ChangeLog entry is a good idea for future patches. I also removed the comment since it's self-explanatory. Thanks!

Note You need to log in before you can comment on or make changes to this bug.