Summary: | Service Worker should use a correct SessionID | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, ews-watchlist, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2017-12-08 08:35:32 PST
Created attachment 328829 [details]
Patch
Created attachment 328831 [details]
Patch
Created attachment 328853 [details]
Patch
Created attachment 328858 [details]
Patch
Attachment 328858 [details] did not pass style-queue:
ERROR: Source/WebCore/workers/service/server/SWServer.cpp:200: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/workers/service/server/SWServer.cpp:202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/workers/service/server/SWServer.cpp:203: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 3 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 328858 [details] Patch Clearing flags on attachment: 328858 Committed r225703: <https://trac.webkit.org/changeset/225703> All reviewed patches have been landed. Closing bug. |