Bug 180585

Summary: Service Worker should use a correct SessionID
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-12-08 08:35:32 PST
Currently it is using a default one.
Attachments
Patch (17.70 KB, patch)
2017-12-08 10:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.39 KB, patch)
2017-12-08 10:34 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.20 KB, patch)
2017-12-08 12:29 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.21 KB, patch)
2017-12-08 13:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-08 10:24:43 PST
Created attachment 328829 [details] Patch
youenn fablet
Comment 2 2017-12-08 10:34:32 PST
Created attachment 328831 [details] Patch
youenn fablet
Comment 3 2017-12-08 12:29:54 PST
Created attachment 328853 [details] Patch
youenn fablet
Comment 4 2017-12-08 13:07:09 PST
Created attachment 328858 [details] Patch
EWS Watchlist
Comment 5 2017-12-08 13:09:13 PST
Attachment 328858 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/server/SWServer.cpp:200: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/workers/service/server/SWServer.cpp:202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/workers/service/server/SWServer.cpp:203: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 3 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2017-12-08 14:44:30 PST
Comment on attachment 328858 [details] Patch Clearing flags on attachment: 328858 Committed r225703: <https://trac.webkit.org/changeset/225703>
WebKit Commit Bot
Comment 7 2017-12-08 14:44:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-12-08 14:45:36 PST
<rdar://problem/35944220>
Note You need to log in before you can comment on or make changes to this bug.