Bug 180581 – [GTK] Issues with Ahem's ex / x-height

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Cairo does not allow us to extract the defined x-height from a font, and we instead need to draw an "x" and measure it with cairo_scaled_font_text_extents.

The Ahem font has a defined x-height of 0.8em, which does not seem to match the result of cairo_scaled_font_text_extents.

This causes a number of our tests that use the font to fail on GTK.

[Carlos Garcia Campos]

Created attachment 330372 [details]
Patch

With this patch we get different (and better?) results for those tests, but most of them still fail. I'm getting the same results with chromium though, so maybe we can consider them good enough and simply rebaseline.

[EWS Watchlist]

Comment on attachment 330372 [details]
Patch

Attachment 330372 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5915758

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html

[EWS Watchlist]

Created attachment 330400 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Carlos Garcia Campos]

Committed r226404: <https://trac.webkit.org/changeset/226404>

[Carlos Garcia Campos]

Landed patch includes a rebaseline. What do we do with the other tests still pointing to this bug in expectations? Do we reopen the bug or rebaseline the tests?

[Ms2ger (he/him; ⌚ UTC+1/+2)]

The other tests are based on testharness.js. As long as there's FAILs in the output, I think we need a bug for them.