Summary: | [WTF] Remove remaining use of Mutex | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, mark.lam, saam, sam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2017-12-08 05:02:24 PST
Created attachment 328803 [details]
Patch
Created attachment 328804 [details]
Patch
Attachment 328804 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/threads/BinarySemaphore.cpp:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328809 [details]
Patch
Attachment 328809 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/threads/BinarySemaphore.cpp:41: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
WinCairo failure seems related to incremental build issue. Comment on attachment 328809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328809&action=review > Source/WTF/wtf/win/WorkQueueWin.cpp:159 > + HANDLE timer { 0 }; I think this could be nullptr. Comment on attachment 328809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328809&action=review Thanks! >> Source/WTF/wtf/win/WorkQueueWin.cpp:159 >> + HANDLE timer { 0 }; > > I think this could be nullptr. Nice, fixed. Committed r225681: <https://trac.webkit.org/changeset/225681> |