Bug 180540

Summary:

Use fastAlignedFree to free aligned memory.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

JavaScriptCore

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none

Per Arne Vollan

Reported 2017-12-07 12:45:47 PST

When memory is allocated with tryFastAlignedMalloc, I believe we should use fastAlignedFree to free the memory.

Attachments
Patch (1.18 KB, patch) 2017-12-07 12:46 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.56 MB, application/zip) 2017-12-07 13:56 PST, EWS Watchlist	no flags	Details
Patch (1.18 KB, patch) 2017-12-07 14:14 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2017-12-07 12:46:49 PST

Created attachment 328717 [details] Patch

Saam Barati

Comment 2 2017-12-07 12:50:59 PST

Comment on attachment 328717 [details] Patch r=me

EWS Watchlist

Comment 3 2017-12-07 13:56:41 PST

Comment on attachment 328717 [details] Patch Attachment 328717 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5533377 New failing tests: http/tests/workers/service/Client-properties-auxiliary.html

EWS Watchlist

Comment 4 2017-12-07 13:56:42 PST

Created attachment 328734 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Per Arne Vollan

Comment 5 2017-12-07 14:14:13 PST

Created attachment 328740 [details] Patch

Per Arne Vollan

Comment 6 2017-12-07 15:57:30 PST

(In reply to Saam Barati from comment #2) > Comment on attachment 328717 [details] > Patch > > r=me Thanks for reviewing! It seems the mac-wk2 ews failure was a flaky failure. When I uploaded the patch a second time, it passed ews.

WebKit Commit Bot

Comment 7 2017-12-07 16:18:03 PST

Comment on attachment 328717 [details] Patch Clearing flags on attachment: 328717 Committed r225652: <https://trac.webkit.org/changeset/225652>

WebKit Commit Bot

Comment 8 2017-12-07 16:18:05 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2017-12-07 16:20:50 PST

<rdar://problem/35922728>

Note You need to log in before you can comment on or make changes to this bug.