Bug 180515

Summary: Add logging for EditorState in RemoteLayerTree transactions
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Description Simon Fraser (smfr) 2017-12-06 17:33:28 PST 
Add logging for EditorState in RemoteLayerTree transactions
Comment 1 Simon Fraser (smfr) 2017-12-06 17:35:32 PST 
Created attachment 328663 [details]
Patch
Comment 2 Wenson Hsieh 2017-12-06 18:42:18 PST 
Comment on attachment 328663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328663&action=review

> Source/WebKit/Shared/EditorState.cpp:240
> +    if (editorState.postLayoutData().typingAttributes != AttributeNone)

This probably should only try to dump post layout data if !isMissingPostLayoutData. Otherwise, it'll hit an assertion in debug builds.
Comment 3 Simon Fraser (smfr) 2017-12-07 16:16:42 PST 
https://trac.webkit.org/r225651
Comment 4 Radar WebKit Bug Importer 2017-12-07 16:18:52 PST 
<rdar://problem/35922667>