Bug 180505

Summary: Web Inspector: Canvas: spurious warnings shown for commands that changed pixel contents
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Recording w/ bogus warnings
none
Patch none

Matt Baker
Reported 2017-12-06 14:07:37 PST
Summary: Spurious warnings shown for commands that changed pixel contents. Steps to Reproduce: 1. Goto https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_animations 2. Record the "stopwatch" canvas animation 3. Filter to only show drawing commands => Every command includes a warning that "This action causes no visual change"
Attachments
[Image] Recording w/ bogus warnings (332.55 KB, image/png)
2017-12-06 14:09 PST, Matt Baker 		no flags
Details
Patch (2.76 KB, patch)
2017-12-06 14:55 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-12-06 14:09:28 PST
Created attachment 328625 [details] [Image] Recording w/ bogus warnings
Radar WebKit Bug Importer
Comment 2 2017-12-06 14:10:09 PST
<rdar://problem/35891651>
Blaze Burg
Comment 3 2017-12-06 14:46:28 PST
Devin, can you take a look?
Devin Rousso
Comment 4 2017-12-06 14:55:39 PST
Created attachment 328635 [details] Patch
Devin Rousso
Comment 5 2017-12-06 14:56:16 PST
(In reply to Brian Burg from comment #3) > Devin, can you take a look? My fault. I forgot a `!` 😁
Blaze Burg
Comment 6 2017-12-06 15:24:17 PST
Comment on attachment 328635 [details] Patch r=me
WebKit Commit Bot
Comment 7 2017-12-06 16:02:58 PST
Comment on attachment 328635 [details] Patch Clearing flags on attachment: 328635 Committed r225602: <https://trac.webkit.org/changeset/225602>
WebKit Commit Bot
Comment 8 2017-12-06 16:03:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.