|Summary:||Move all tests under http/tests/loading/resourceLoadStatistics/ to http/tests/resourceLoadStatistics/ and remove expected failures|
|Product:||WebKit||Reporter:||John Wilander <wilander>|
|Component:||Tools / Tests||Assignee:||John Wilander <wilander>|
|Severity:||Normal||CC:||bfulgham, commit-queue, ews-watchlist, jlewis3, lforschler, rniwa, ryanhaddad, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description John Wilander 2017-12-06 13:57:23 PST
Having the resource load statistics tests under http/tests/loading/ was a mistake since it causes text diff flakiness with load order of frames. We should move all tests one step up, under http/tests/resourceLoadStatistics/, work them through, and mark them [ Pass ].
Comment 4 EWS Watchlist 2017-12-06 15:35:09 PST
Comment on attachment 328627 [details] Patch Attachment 328627 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5521095 New failing tests: http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
Comment 5 EWS Watchlist 2017-12-06 15:35:11 PST
Created attachment 328639 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment 6 EWS Watchlist 2017-12-06 15:57:04 PST
Comment on attachment 328627 [details] Patch Attachment 328627 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5521186 New failing tests: http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html
Comment 7 EWS Watchlist 2017-12-06 15:57:06 PST
Created attachment 328642 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment 9 John Wilander 2017-12-06 16:18:10 PST
(In reply to Build Bot from comment #4) > Comment on attachment 328627 [details] > Patch > > Attachment 328627 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/5521095 > > New failing tests: > http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie- > deletion.html > http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user- > interaction.html > http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user- > interaction.html > http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with- > partitioning-timeout.html These were failing because cookie partitioning is not a thing on El Cap.
Comment 11 John Wilander 2017-12-06 17:27:46 PST
Skipped … http/tests/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html http/tests/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html … on iOS since UIHelper.activateAt() doesn't produce a user gesture that ITP captures on iOS. This is the reason why we also skip http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html on iOS.
Comment 12 Brent Fulgham 2017-12-06 20:00:50 PST
Comment on attachment 328660 [details] Patch Did you use "svn mv" to relocate these files? We want to make sure we retain svn history. r=me if you did 'svn mv'
Comment 13 John Wilander 2017-12-07 09:44:59 PST
Created attachment 328699 [details] Patch for landing
Comment 14 John Wilander 2017-12-07 09:45:53 PST
(In reply to Brent Fulgham from comment #12) > Comment on attachment 328660 [details] > Patch > > Did you use "svn mv" to relocate these files? We want to make sure we retain > svn history. > > r=me if you did 'svn mv' I hadn't, but now I have. Thanks for pointing this out.
Comment 15 WebKit Commit Bot 2017-12-07 12:09:32 PST
Comment on attachment 328699 [details] Patch for landing Clearing flags on attachment: 328699 Committed r225640: <https://trac.webkit.org/changeset/225640>
Comment 16 WebKit Commit Bot 2017-12-07 12:09:34 PST
All reviewed patches have been landed. Closing bug.