Bug 180495

Summary: [WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, fpizlo, ggaren, mark.lam, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180691
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-12-06 12:34:33 PST
[WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
Attachments
Patch (15.69 KB, patch)
2017-12-06 12:37 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (18.75 KB, patch)
2017-12-06 13:15 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (15.69 KB, patch)
2017-12-06 14:00 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-12-06 12:37:09 PST
Created attachment 328607 [details] Patch
Yusuke Suzuki
Comment 2 2017-12-06 12:44:27 PST
We will extend it for bmalloc.
Yusuke Suzuki
Comment 3 2017-12-06 13:15:27 PST
Created attachment 328613 [details] Patch
Yusuke Suzuki
Comment 4 2017-12-06 14:00:05 PST
Hm, in the meantime, I disable bmalloc's change.
Yusuke Suzuki
Comment 5 2017-12-06 14:00:27 PST
Created attachment 328623 [details] Patch
Mark Lam
Comment 6 2017-12-06 14:28:12 PST
Comment on attachment 328623 [details] Patch Very nice. r=me
Yusuke Suzuki
Comment 7 2017-12-06 19:31:28 PST
Comment on attachment 328623 [details] Patch Thanks!
WebKit Commit Bot
Comment 8 2017-12-06 19:52:12 PST
Comment on attachment 328623 [details] Patch Clearing flags on attachment: 328623 Committed r225617: <https://trac.webkit.org/changeset/225617>
WebKit Commit Bot
Comment 9 2017-12-06 19:52:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-12-06 19:53:37 PST
<rdar://problem/35900197>
Note You need to log in before you can comment on or make changes to this bug.