Bug 180495

Summary: [WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, fpizlo, ggaren, mark.lam, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180691
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Yusuke Suzuki 2017-12-06 12:34:33 PST
[WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
Comment 1 Yusuke Suzuki 2017-12-06 12:37:09 PST
Created attachment 328607 [details]
Patch
Comment 2 Yusuke Suzuki 2017-12-06 12:44:27 PST
We will extend it for bmalloc.
Comment 3 Yusuke Suzuki 2017-12-06 13:15:27 PST
Created attachment 328613 [details]
Patch
Comment 4 Yusuke Suzuki 2017-12-06 14:00:05 PST
Hm, in the meantime, I disable bmalloc's change.
Comment 5 Yusuke Suzuki 2017-12-06 14:00:27 PST
Created attachment 328623 [details]
Patch
Comment 6 Mark Lam 2017-12-06 14:28:12 PST
Comment on attachment 328623 [details]
Patch

Very nice.  r=me
Comment 7 Yusuke Suzuki 2017-12-06 19:31:28 PST
Comment on attachment 328623 [details]
Patch

Thanks!
Comment 8 WebKit Commit Bot 2017-12-06 19:52:12 PST
Comment on attachment 328623 [details]
Patch

Clearing flags on attachment: 328623

Committed r225617: <https://trac.webkit.org/changeset/225617>
Comment 9 WebKit Commit Bot 2017-12-06 19:52:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-06 19:53:37 PST
<rdar://problem/35900197>