Bug 180493

Summary: Layout Test media/event-queue-crash.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, graouts, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Matt Lewis 2017-12-06 12:25:15 PST
media/event-queue-crash.html is a flaky failure on macOS. According to the dashboard it has flaked on High Sierra Release, Sierra Debug WK1, and El Capitan Release WK2:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fevent-queue-crash.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r225575%20(1576)/results.html
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/1576

There isn't a clear regression point on the dashboard. 

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/media/event-queue-crash-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/media/event-queue-crash-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 34: SyntaxError: Unexpected token '}'. Expected '(' to start an 'if' condition.
 When an element containing video is removed, WebKit should not crash.
 
 PASS. WebKit didn't crash.
Comment 1 Radar WebKit Bug Importer 2017-12-07 11:29:50 PST
<rdar://problem/35914377>
Comment 2 Alexey Proskuryakov 2017-12-08 17:01:38 PST
Matt, is this reproducible?
Comment 3 Matt Lewis 2018-01-10 13:06:05 PST
Yes, I was able to reproduce the failure on High Sierra however I had to run this multiple times to get the failure:
run-webkit-tests media/event-queue-crash.html --no-retry-failure --verbose --iterations=50 -f -g
Comment 4 Eric Carlson 2018-01-10 15:42:13 PST
Created attachment 330978 [details]
Patch
Comment 5 Eric Carlson 2018-01-11 08:24:08 PST
Created attachment 331056 [details]
Patch
Comment 6 WebKit Commit Bot 2018-01-11 10:20:18 PST
Comment on attachment 331056 [details]
Patch

Clearing flags on attachment: 331056

Committed r226785: <https://trac.webkit.org/changeset/226785>
Comment 7 WebKit Commit Bot 2018-01-11 10:20:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Matt Lewis 2018-01-11 13:14:37 PST
Re-baselined test in: https://trac.webkit.org/changeset/226798/webkit