Bug 180478

Summary: StartFetch should take a ServiceWorkerIdentifier
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2017-12-06 09:01:36 PST
Currently it takes an optional ServiceWorkerIdentifier which is not needed right now.
Attachments
Patch (12.33 KB, patch)
2017-12-06 09:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.34 KB, patch)
2017-12-06 12:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.80 KB, patch)
2017-12-07 18:00 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-06 09:06:25 PST
Created attachment 328576 [details] Patch
Brady Eidson
Comment 2 2017-12-06 12:55:45 PST
Comment on attachment 328576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328576&action=review > Source/WebKit/ChangeLog:11 > + In the case,there is a problem in running the service worker at start fetch time, Missing space after comma
youenn fablet
Comment 3 2017-12-06 12:57:44 PST
Created attachment 328612 [details] Patch for landing
youenn fablet
Comment 4 2017-12-07 18:00:02 PST
Created attachment 328766 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-12-07 18:33:39 PST
Comment on attachment 328766 [details] Patch for landing Clearing flags on attachment: 328766 Committed r225665: <https://trac.webkit.org/changeset/225665>
WebKit Commit Bot
Comment 6 2017-12-07 18:33:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-12-07 18:34:46 PST
<rdar://problem/35925781>
Note You need to log in before you can comment on or make changes to this bug.