| Summary: | InferredType should not use UnconditionalFinalizer | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 180248 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Filip Pizlo
2017-12-05 16:25:43 PST
Created attachment 328523 [details]
it's a start
Created attachment 328538 [details]
the patch
Comment on attachment 328538 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=328538&action=review > Source/JavaScriptCore/runtime/InferredType.cpp:90 > + if (inferredType->m_structure) > + visitor.append(inferredType->m_structure); Doesn't append already do a null check for you? (In reply to Saam Barati from comment #3) > Comment on attachment 328538 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328538&action=review > > > Source/JavaScriptCore/runtime/InferredType.cpp:90 > > + if (inferredType->m_structure) > > + visitor.append(inferredType->m_structure); > > Doesn't append already do a null check for you? Yeah you're right! Comment on attachment 328538 [details] the patch Attachment 328538 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5508914 Number of test failures exceeded the failure limit. Created attachment 328543 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 328546 [details]
patch for landing
This fixes some crashes
|