Bug 180456

Summary: InferredType should not use UnconditionalFinalizer
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 180248    
Attachments:
Description Flags
it's a start
none
the patch
sbarati: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews115 for mac-elcapitan
none
patch for landing none

Description Filip Pizlo 2017-12-05 16:25:43 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2017-12-05 16:27:10 PST
Created attachment 328523 [details]
it's a start
Comment 2 Filip Pizlo 2017-12-05 17:32:49 PST
Created attachment 328538 [details]
the patch
Comment 3 Saam Barati 2017-12-05 17:39:35 PST
Comment on attachment 328538 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328538&action=review

> Source/JavaScriptCore/runtime/InferredType.cpp:90
> +    if (inferredType->m_structure)
> +        visitor.append(inferredType->m_structure);

Doesn't append already do a null check for you?
Comment 4 Filip Pizlo 2017-12-05 17:42:25 PST
(In reply to Saam Barati from comment #3)
> Comment on attachment 328538 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328538&action=review
> 
> > Source/JavaScriptCore/runtime/InferredType.cpp:90
> > +    if (inferredType->m_structure)
> > +        visitor.append(inferredType->m_structure);
> 
> Doesn't append already do a null check for you?

Yeah you're right!
Comment 5 EWS Watchlist 2017-12-05 18:41:22 PST
Comment on attachment 328538 [details]
the patch

Attachment 328538 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5508914

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2017-12-05 18:41:23 PST
Created attachment 328543 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Filip Pizlo 2017-12-05 19:08:59 PST
Created attachment 328546 [details]
patch for landing

This fixes some crashes
Comment 8 Filip Pizlo 2017-12-09 11:48:26 PST
Landed in https://trac.webkit.org/changeset/225725/webkit
Comment 9 Radar WebKit Bug Importer 2017-12-09 11:49:26 PST
<rdar://problem/35953018>