Bug 180450

Summary:

ServiceWorkerGlobalScope prototype chain should be immutable

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, mark.lam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Chris Dumez

Reported 2017-12-05 14:56:08 PST

ServiceWorkerGlobalScope prototype chain should be immutable. Covered by: imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html

Attachments
Patch (24.63 KB, patch) 2017-12-05 16:49 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (26.27 KB, patch) 2017-12-05 20:15 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-12-05 16:49:53 PST

Created attachment 328525 [details] Patch

youenn fablet

Comment 2 2017-12-05 18:37:09 PST

Comment on attachment 328525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328525&action=review > Source/WebCore/ChangeLog:9 > + do what we do for DOMWindow. This is covered by a web-platform-test s/do/to > Source/WebCore/workers/DedicatedWorkerGlobalScope.idl:37 > + IsImmutablePrototypeExoticObjectOnPrototype, It seems we have no tests for this change. We should probably import WPT workers test suite to cover this (and maybe much more!).

youenn fablet

Comment 3 2017-12-05 19:15:02 PST

Filed bug 180464 for wpt worker test suite

Chris Dumez

Comment 4 2017-12-05 20:15:21 PST

Created attachment 328548 [details] Patch

WebKit Commit Bot

Comment 5 2017-12-05 20:47:03 PST

Comment on attachment 328548 [details] Patch Clearing flags on attachment: 328548 Committed r225566: <https://trac.webkit.org/changeset/225566>

WebKit Commit Bot

Comment 6 2017-12-05 20:47:05 PST

All reviewed patches have been landed. Closing bug.